Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openssl build now fails in Tor build script. #2314

Closed
nmathewson opened this issue Apr 12, 2019 · 7 comments
Closed

Openssl build now fails in Tor build script. #2314

nmathewson opened this issue Apr 12, 2019 · 7 comments

Comments

@nmathewson
Copy link
Contributor

It looks like the way we're building OpenSSL for Tor broke again in the past week or so. When the script tries to produce a shared library, it gives all kinds of linker errors about missing asan symbols, such as:
{{{
Step #4: crypto/fips-dso-cryptlib.o: In function OPENSSL_die': Step #4: /src/openssl/crypto/cryptlib.c:421: undefined reference to __asan_handle_no_return'
}}}

Has anybody else run into this kind of thing? The OpenSSL makefile and the hacky options that we pass to it are sufficiently complicated that I am not quite sure how to approach this myself.

@Dor1s
Copy link
Contributor

Dor1s commented Apr 12, 2019

A standalone openssl build is broken for more than a week as well: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14075

@kroeckx do you know what could've changed?

@kroeckx
Copy link
Contributor

kroeckx commented Apr 12, 2019

I've just filed openssl/openssl#8735, which I think is the problem.

@nmathewson
Copy link
Contributor Author

Thanks! I'll keep an eye on it.

@jonathanmetzman
Copy link
Contributor

openssl/openssl#8749 landed but openssl and tor builds still failing.

@jonathanmetzman
Copy link
Contributor

Recent envoy and Tor builds have been succeeding. @Dor1s I think this can be closed right?

@Dor1s
Copy link
Contributor

Dor1s commented May 13, 2019

Yes, Sir! Thanks!

@jonathanmetzman
Copy link
Contributor

Sorry I meant to post the previous comment on #2315 but this issue can be closed too as openssl and tor builds have been succeeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants