Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to ensure that infra/helper.py is running with latest clang #302

Closed
inferno-chromium opened this issue Jan 20, 2017 · 2 comments
Closed
Assignees

Comments

@inferno-chromium
Copy link
Collaborator

We need to run ./infra/base-images/all.sh explicitly to update clang. OSS-Fuzz developers might continue to keep using old clang if they don't call this. E.g. i could n't reproduce that lld breakage since my clang locally was old.

@mikea
Copy link
Contributor

mikea commented Jan 20, 2017

That's what docker build --pull is for in helper.py - it checks for image version on every build.
We also do a push right after base-images build. The image should be reasonable fresh. Do you remember what did you do exactly?

@inferno-chromium
Copy link
Collaborator Author

I remember seeing the lld flag unsupported on line
"Compiling libFuzzer to /usr/lib/libFuzzingEngine.a"
with the build_fuzzers command, can't reproduce it anymore. Maybe the image wasn't up-to-date yesterday when i pulled, and now it is. Closing.

DavidKorczynski added a commit that referenced this issue Jul 9, 2024
This is to make the output of the CI consistent with the environment in
which experiments run. It's now set to match:
https:/google/oss-fuzz-gen/blob/68c69a0ef888003371a12cb65b2ba5e27bc1a767/Dockerfile#L41

Otherwise we run into inconsistencies where e.g.
google/oss-fuzz-gen#300 reports:

```sh
Step #1: PR: google/oss-fuzz-gen#300
Step #1: JOB: https://console.cloud.google.com/kubernetes/job/us-central1-c/llm-experiment/default/ofg-pr-300-dk
Step #1: REPORT: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-05-28-300-dk-comparison/index.html
Step #1: BUCKET: https://console.cloud.google.com/storage/browser/oss-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2024-05-28-300-dk-comparison
Step #1: BUCKET GS: `gs://oss-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2024-05-28-300-dk-comparison`
```

The actual URLs are on "...2024-05-29..." e.g.
https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-05-29-300-dk-comparison/index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants