suricata: remove temporary workarounds for suricata #11855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after clang update in google#11714
|
catenacyber is either the primary contact or is in the CCs list of projects/suricata. |
|
I think you may still run into a coverage build issue, due to the raw profile mismatch, but if CI is passing, then it is probably good. |
Could you explain this a bit more ? |
|
Ah nevermind, coverage is only a problem when using a recent rust nightly, but you didn't change that here. You are only removing no longer needed workarounds. LGTM |
maflcko
approved these changes
Apr 30, 2024
DavidKorczynski
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after clang update in #11714
Let's see how CI goes...