Make the bootstrapping process more robust: #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make a new package 'proto-lens-descriptors' for the descriptors - Name those modules "Proto.*" instead of "Bootstrap.Proto.*" - Add special logic so the descriptors modules don't use the reexported modules from proto-lens-protoc (otherwise we'd get a circular dependency) - Make the bootstrapping script use a special stack YAML file.
blackgnezdo
reviewed
Jan 3, 2017
| @@ -0,0 +1,30 @@ | |||
| Copyright Author name here (c) 2017 | |||
| @@ -60,15 +61,21 @@ fileSyntaxType f = case f ^. syntax of | |||
| "" -> Proto2 -- The proto compiler doesn't set syntax for proto2 files. | |||
| s -> error $ "Unknown syntax type " ++ show s | |||
|
|
|||
| -- Whether to import the "Reexport" modules or the originals; | |||
| -- e.g., Data.ProtoLens.Reexport.Data.Map vs Data.Map. | |||
| data UseReexport = UseReexport | UseOriginal | |||
There was a problem hiding this comment.
Maybe change this to [newtype around] ModuleName -> ImportDecl? UseOriginal would become importSimple.
There was a problem hiding this comment.
Switched to ImportDecl -> ImportDecl. Since that type's pretty simple, I don't think it's worth adding a newtype.
|
blackgnezdo
approved these changes
Jan 4, 2017
| @@ -71,11 +72,11 @@ data UseReexport = UseReexport | UseOriginal | |||
| generateModule :: ModuleName | |||
| -> [ModuleName] -- ^ The imported modules | |||
| -> SyntaxType | |||
| -> UseReexport | |||
| -> (ImportDecl -> ImportDecl) | |||
There was a problem hiding this comment.
A type synonym would still be nice for discoverability. You already found a name for it: ModifyImports.
avdv
pushed a commit
to avdv/proto-lens
that referenced
this pull request
Aug 9, 2023
- Make a new package 'proto-lens-descriptors' for the descriptors - Name those modules "Proto.*" instead of "Bootstrap.Proto.*" - Add special logic so the descriptors modules don't use the reexported modules from proto-lens-protoc (otherwise we'd get a circular dependency) - Make the bootstrapping script use a special stack YAML file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modules from proto-lens-protoc (otherwise we'd get a circular dependency)