Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate and deprecate generatedFilesBaseDir #636

Merged
merged 8 commits into from
Jan 5, 2023

Commits on Nov 5, 2022

  1. Emulate and deprecate generatedFilesBaseDir

    Fixes google#33 for users not changing generatedFilesBaseDir. Stop documenting
    generatedFilesBaseDir since it produces poor results, but keep it
    functional with its existing Copy semantics. Fixes google#332
    ejona86 committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    0f6463c View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Use FileSystemOperations when available

    Can't reference project from action
    ejona86 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    adc5f5d View commit details
    Browse the repository at this point in the history
  2. Deprecate setter

    I don't know how to make this trigger a warning, for either Groovy and
    Kotlin. Both seem to ignore it.
    ejona86 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ffcdc38 View commit details
    Browse the repository at this point in the history
  3. Redefine extension as local variable so it is available in the closure

    This fixes `class java.lang.Object cannot be cast to class
    com.google.protobuf.gradle.ProtobufPlugin` in "testProjectAndroid
    succeeds with configuration cache". The configuration cache is somehow
    confusing things, including defeating static typing. Redefining the
    variable locally avoids the reference to ProtobufPlugin.
    ejona86 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f9cf061 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    20e5d2a View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Swap to Property

    ejona86 committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1296159 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a34ea4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f53854d View commit details
    Browse the repository at this point in the history