Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating transitive rules for rename events should fallback to destination path #1299

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

mlw
Copy link
Contributor

@mlw mlw commented Feb 28, 2024

When a transitive rule is being created during a RENAME event, currently only the source path is used. However, the rename operation may have already succeeded and the path no longer exists. This change makes it so that the destination path is used in the event the source no longer exists.

Copy link
Contributor

@pmarkowsky pmarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mlw mlw merged commit 74d8fe3 into google:main Feb 28, 2024
9 checks passed
@mlw mlw added this to the 2024.3 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
santad Work related to the Santa Daemon transitive allowlisting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants