Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlock in log_client #3236

Closed
wants to merge 1 commit into from
Closed

Fix deadlock in log_client #3236

wants to merge 1 commit into from

Conversation

n-canter
Copy link

@n-canter n-canter commented Dec 6, 2023

Deadlock in WaitForRootUpdate() method when UpdateRoot() is called simultaneously.

@n-canter
Fix deadlock in log_client
d2fd619 
Deadlock in WaitForRootUpdate() method when UpdateRoot() is called simultaneously.
@n-canter n-canter requested a review from a team as a code owner December 6, 2023 14:58
@roger2hk
Copy link
Contributor

roger2hk commented Dec 6, 2023

/gcbrun

roger2hk
roger2hk reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@roger2hk roger2hk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could be wrong but it looks like the ctx timeout in WaitForRootUpdate func will break the deadlock.

@n-canter
Copy link
Author

I could be wrong but it looks like the ctx timeout in WaitForRootUpdate func will break the deadlock.

You're right, closing this pr

@n-canter n-canter closed this Dec 11, 2023
@roger2hk roger2hk mentioned this pull request Jan 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger2hk roger2hk roger2hk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-canter @roger2hk