Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Pydantic functions used by the API #1312

Merged
merged 19 commits into from
Jul 24, 2023

Conversation

Igor8mr
Copy link
Contributor

@Igor8mr Igor8mr commented Jul 20, 2023

Updated the Pydantic functions used by the API, removing the json(sort_keys=True) BaseModel method, which is no longer supported, and replacing it with model_dump_json().
Fixed issues #1304 and #1308 .

@jleaniz jleaniz self-requested a review July 21, 2023 02:38
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still in draft but leaving some preliminary comments.

tools/generate_dfvfs_test_data/generate_test_data_linux.sh Outdated Show resolved Hide resolved
tools/generate_dfvfs_test_data/generate_test_data_macos.sh Outdated Show resolved Hide resolved
turbinia/api/client/turbinia_api_lib/rest.py Outdated Show resolved Hide resolved
turbinia/api/routes/request.py Outdated Show resolved Hide resolved
@Igor8mr Igor8mr marked this pull request as draft July 21, 2023 15:17
@Igor8mr Igor8mr marked this pull request as ready for review July 21, 2023 21:13
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleaniz jleaniz merged commit c46738a into google:master Jul 24, 2023
5 checks passed
@Igor8mr Igor8mr deleted the API-Summary-Fix branch July 24, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants