Some googleclouddisk e2e test improvements #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hacktobeer
commented
Oct 16, 2020
hacktobeer
commented
- IAM roles and service account are cleaned up when test is done
- debug flag is set for each turbiniactl command
- e2e return value parsing improvements
- include GCS stored output of each task in local archive (excluding StringAsciiTask on whole disk due to size)
|
Travis fails with "ImportError: cannot import name 'collections_abc'" <- this seems to be something else and nothing to do with the changes in this PR. |
|
Yeah, I filed #604 for the unrelated test error, and I'm still looking into it, but it seems like it's a version conflict in upstream cloud libraries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.