Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the CI part of dev/changelog into main #647

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Merge the CI part of dev/changelog into main #647

merged 10 commits into from
Oct 22, 2024

Conversation

ia0
Copy link
Member

@ia0 ia0 commented Oct 21, 2024

Part of #448 and #208.

exzachlyvv and others added 9 commits September 1, 2024 18:54
End goal ([bug](google#448)): Create
script to automate updating CHANGELOG.md

This task will be done in 2 parts:
1. `xtask changelog ci`: validates all CHANGELOG.md files <-- this PR
2. `xtask changelog {major,minor,patch}`: automatically updates
changelogs with a new description.

---------

Co-authored-by: ia0 <[email protected]>
…ogle#595)

Diff will clean up after PR google#584 is merged

---------

Co-authored-by: Julien Cretin <[email protected]>
@ia0 ia0 added crate:cli Modifies the users CLI crate:xtask Modifies the maintainers CLI for:maintainability Improves maintainers life labels Oct 21, 2024
Copy link

google-cla bot commented Oct 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ia0 ia0 requested a review from ia0-review October 21, 2024 15:24
@ia0 ia0 merged commit ea331ec into google:main Oct 22, 2024
21 checks passed
@ia0 ia0 deleted the changelog branch October 22, 2024 10:20
Copy link
Collaborator

@exzachlyvv exzachlyvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late but LGTM, nice changes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate:cli Modifies the users CLI crate:xtask Modifies the maintainers CLI for:maintainability Improves maintainers life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants