Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weather-sp's templating system to allow users to specify level and shortname. #105

Merged
merged 13 commits into from
Feb 10, 2022

Conversation

alxmrs
Copy link
Collaborator

@alxmrs alxmrs commented Feb 8, 2022

Fixes #102. In addition, file endings are no longer needed -- now, we attempt to read the file to determine which splitter to use.

@alxmrs alxmrs requested a review from uhager February 8, 2022 22:27
weather_sp/README.md Outdated Show resolved Hide resolved
weather_sp/README.md Outdated Show resolved Hide resolved
weather_sp/splitter_pipeline/file_name_utils.py Outdated Show resolved Hide resolved
@alxmrs alxmrs requested a review from uhager February 10, 2022 18:22
if ending in [*GRIB_FILE_ENDINGS, *NETCDF_FILE_ENDINGS]:
file_ending = ending
if ending in GRIB_FILE_ENDINGS or ending in NETCDF_FILE_ENDINGS:
ending = ending
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤦🏽

@alxmrs alxmrs merged commit 128a028 into main Feb 10, 2022
@alxmrs alxmrs deleted the sp-improvements branch February 10, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitter template syntax is not expressive enough for backwards compatability.
2 participants