Suppress urllib3 warning #134
Conversation
|
|
||
| import cdsapi | ||
| from ecmwfapi import ECMWFService | ||
|
|
||
| warnings.simplefilter( | ||
| "ignore", category=urllib3.connectionpool.InsecureRequestWarning) | ||
|
|
There was a problem hiding this comment.
Looks fine to me. The only thought I have here is: should we do this for the CDS client only? WDYT?
There was a problem hiding this comment.
I'm not sure I understood your meaning. Are you suggesting this be added in other files too? I wasn't actually sure the best place to add it, so I can put it wherever you suggest.
There was a problem hiding this comment.
There's a CDS Client in this file, and that seems to be where the warnings are coming from. My suggestion was more or less: what if we put this on line 87 (the constructor of CdsClient)?
This way, it will only suppress these warnings. I can see an argument how we'd like to prevent this error trace form occurring everywhere, in which case we'd leave this line as is.
pbattaglia
force-pushed
the
suppress_urllib3_warning
branch
from
a983abe
to
afba559
Compare
|
Merging for now, we can revisit this warning suppression later. |
This comes from urllib3 through cdsapi. It spams logging output in local runs, but doesn't seem important.
Here's what it looks like: