Robust download from clients to VMs. #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #140 with a few tactics. First, I've added a check to skip a partition during the fetch step. Thus, if this step fails and restarts, it won't re-download from the beginning anymore. This functions as a fallback mechanism. Second, we add retry logic that will catch a common source of error: socket timeouts during download from remote servers. This should prevent the ParDo step from failing in the first place.
Thanks to @uhager for identifying this bug.