Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DL: Add support for MARS syntax in JSON config #163

Merged
merged 14 commits into from
Jun 16, 2022
Merged

DL: Add support for MARS syntax in JSON config #163

merged 14 commits into from
Jun 16, 2022

Conversation

deepgabani8
Copy link
Collaborator

Fixes #48 .

@deepgabani8 deepgabani8 changed the title DL: enhance mars config json DL: Add support for MARS syntax in JSON config Jun 13, 2022
@mahrsee1997 mahrsee1997 requested a review from alxmrs June 13, 2022 16:21
alxmrs
alxmrs requested changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@alxmrs alxmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far – I've left a couple of notes.

weather_dl/download_pipeline/parsers.py Outdated Show resolved Hide resolved
weather_dl/download_pipeline/parsers_test.py Outdated Show resolved Hide resolved
weather_dl/download_pipeline/parsers.py Outdated Show resolved Hide resolved
weather_dl/download_pipeline/parsers_test.py Outdated Show resolved Hide resolved
@deepgabani8 deepgabani8 requested a review from alxmrs June 14, 2022 14:58
alxmrs
alxmrs approved these changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@alxmrs alxmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits. Otherwise, this change looks great! Please merge this when the outstanding issues have been addressed.

@deepgabani8 deepgabani8 merged commit b630921 into google:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxmrs alxmrs alxmrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON files do not support MARs range syntax.
2 participants
@deepgabani8 @alxmrs