Ingested grid point as a polygon in BigQuery. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxmrs
reviewed
May 30, 2023
weather_mv/loader_pipeline/bq.py
Outdated
Comment on lines
279
to
281
| for i, _ in enumerate(lat_lon_bound): | ||
| if lat_lon_bound[i][1] >= 180: | ||
| lat_lon_bound[i][1] = lat_lon_bound[i][1] - 360 |
There was a problem hiding this comment.
Suggested change
| for i, _ in enumerate(lat_lon_bound): | |
| if lat_lon_bound[i][1] >= 180: | |
| lat_lon_bound[i][1] = lat_lon_bound[i][1] - 360 | |
| for i in range(len(lat_lon_bound)): | |
| if lat_lon_bound[i][1] >= 180: | |
| lat_lon_bound[i][1] = lat_lon_bound[i][1] - 360 |
There was a problem hiding this comment.
I have a question for @wundersooner: Should we be cautious here? Is this specific to one coordinate system?
There was a problem hiding this comment.
I would be cautious here. Some coordinate systems use x,y coordinates in meters instead of degree-based lon, lat.
alxmrs
reviewed
May 31, 2023
alxmrs
reviewed
Jun 28, 2023
alxmrs
reviewed
Jun 28, 2023
alxmrs
reviewed
Jun 28, 2023
alxmrs
reviewed
Jun 29, 2023
alxmrs
reviewed
Jun 29, 2023
alxmrs
reviewed
Jun 29, 2023
alxmrs
reviewed
Jul 10, 2023
alxmrs
reviewed
Jul 10, 2023
alxmrs
reviewed
Jul 10, 2023
alxmrs
reviewed
Jul 10, 2023
alxmrs
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @alxmrs, as per our earlier conversation in discussion #266, I have implemented the code to ingest grid points as
polygonsin BigQuery. Currently, the code creates a polygon by considering the givenlatitudeandlongitudeas thecenterof the polygon.Note: This implementation only works for a regular_ll grid.