Fix : for a added feature in weather-mv to extract specific date's data from zarr files. #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxmrs
reviewed
Oct 3, 2023
alxmrs
reviewed
Oct 3, 2023
alxmrs
reviewed
Oct 3, 2023
alxmrs
reviewed
Oct 3, 2023
| @@ -311,6 +315,10 @@ def expand(self, paths): | |||
| xarray_open_dataset_kwargs = self.xarray_open_dataset_kwargs.copy() | |||
| xarray_open_dataset_kwargs.pop('chunks') | |||
| ds, chunks = xbeam.open_zarr(self.first_uri, **xarray_open_dataset_kwargs) | |||
|
|
|||
| if self.start_date is not None and self.end_date is not None: | |||
There was a problem hiding this comment.
Would this be useful for non-Zarr datasets? I'm on the fence.
There was a problem hiding this comment.
The PR: #396 is useful for the non-zarr datasets and this PR will be working on zarr datasets.
alxmrs
reviewed
Oct 3, 2023
alxmrs
reviewed
Oct 4, 2023
alxmrs
reviewed
Oct 4, 2023
alxmrs
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #396 I have added a feature in weather-mv which can allows users to access data for a specific date from zarr files but that is not working properly.
BQ ingestion of zarr data is done through the
expand functionand in this function we can't get value ofstart_dateandend_datefromxarray_open_dataset_kwargsdict. So I added this code, using of we get the value ofstart_date&end_datefrom thezarr_kwargs.