weather-mv: Implemented streaming import of data into BigQuery.
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxmrs
commented
Dec 31, 2021
|
Pre-requisite: #62. |
- Includes re-implementing math.prod for Python 3.7 compatability.
pramodg
reviewed
Jan 7, 2022
| @@ -207,9 +215,10 @@ def get_coordinates(ds: xr.Dataset) -> t.Iterator[t.Dict]: | |||
| # Example: | |||
| # {'longitude': -108.0, 'latitude': 49.0, 'time': '2018-01-02T23:00:00+00:00'} | |||
| idx = 0 | |||
| total_coords = _prod(ds.coords.dims.values()) | |||
There was a problem hiding this comment.
minor note: dims may not give you the right set,
IIRC indexes was a subset of dims (check one of the grib test files.)
There was a problem hiding this comment.
Aren't the dims of the coords the correct subset? I just ran a small experiment:
>>> ds = xr.open_dataset(gb, engine='cfgrib') # gb is a path to test_data_grib_single_timestamp
>>> [len(x) for x in ds.coords.indexes.values()]
[1801, 3600]
>>> ds.coords.dims.values()
ValuesView(Frozen({'latitude': 1801, 'longitude': 3600}))
pramodg
reviewed
Jan 7, 2022
pramodg
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.
TODO:
weather-mv's documentation to reflect the new functionality.