Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default behavior is better #77

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Default behavior is better #77

merged 1 commit into from
Jan 12, 2022

Conversation

lakshmanok
Copy link
Contributor

@lakshmanok lakshmanok commented Jan 12, 2022

We want the default behavior as described in the Apache Beam documentation:

method – The method to use to write to BigQuery. It may be STREAMING_INSERTS, FILE_LOADS, or DEFAULT. DEFAULT will use STREAMING_INSERTS on Streaming pipelines and FILE_LOADS on Batch pipelines.

Batch loads are free and much more efficient for large datasets, so on batch pipelines, that is what we want to do.

[1]https://beam.apache.org/releases/pydoc/2.35.0/apache_beam.io.gcp.bigquery.html#:~:text=DEFAULT%20will%20use%20STREAMING_INSERTS%20on%20Streaming%20pipelines%20and%20FILE_LOADS%20on%20Batch%20pipelines.

We want the default behavior as described in the Apache Beam documentation:
```
method – The method to use to write to BigQuery. It may be STREAMING_INSERTS, FILE_LOADS, or DEFAULT. DEFAULT will use STREAMING_INSERTS on Streaming pipelines and FILE_LOADS on Batch pipelines.
```[1]

Batch loads are free and much more efficient for large datasets, so on batch pipelines, that is what we want to do.

[1]https://beam.apache.org/releases/pydoc/2.35.0/apache_beam.io.gcp.bigquery.html#:~:text=DEFAULT%20will%20use%20STREAMING_INSERTS%20on%20Streaming%20pipelines%20and%20FILE_LOADS%20on%20Batch%20pipelines.
Copy link
Collaborator

@alxmrs alxmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alxmrs alxmrs merged commit 80a5489 into google:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants