Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude test data from tarball #93

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Exclude test data from tarball #93

merged 3 commits into from
Jan 19, 2022

Conversation

CillianFn
Copy link
Contributor

@CillianFn CillianFn commented Jan 19, 2022 •
edited
Loading

#70
Verified this works locally using python setup.py sdist in both weather_mv and weather_sp

alxmrs
alxmrs approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@alxmrs alxmrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@CillianFn
Copy link
Contributor Author

@alxmrs np 😄 you asked on another PR, I don't have merge rights so I can't merge this.

@alxmrs alxmrs merged commit e73d18b into google:main Jan 19, 2022
@alxmrs alxmrs mentioned this pull request Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxmrs alxmrs alxmrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CillianFn @alxmrs