HTML partial support #890
Open
HTML partial support #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gulp will now scan default @@tags in html files and replace those with content of included files To follow the live-reloading functionality, html files are now watched and compiled to the .tmp folder
The proposed structure is based on the components from material design lite. *basic.html is intentionally left untouched
Written a tiny description of included changes.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Any news on this? |
|
I pulled these changes into my project and it worked a charm. +1 to add this to main branch. |
|
I would like to suggest that instead of constraining partials into a folder, they could instead be prefixed with an underscore. This would leave more room with folder structure and seems compliant with what is usually done with Sass. |
ghost
approved these changes
Mar 27, 2017
afifah1978
approved these changes
Apr 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #889, provides a basic ability to separate big and ugly html files into smaller partials, without adding any complicated template engine.