-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wire: can't handle varargs #61
Comments
@zombiezen can you triage this and summarize what would need to be done to support it? |
Based on the failure that @ijt provided, it appears that Wire is correctly determining the type in analysis, but is emitting incorrect code during the generation step. The change should be straightforward, as Wire changes go:
This would be a good Wire starter project, as this plumbs a feature through the whole program. |
@shantuo, want to try your hand at this issue? |
Describe the bug
Wire can't handle functions with varargs.
To Reproduce
google/go-cloud@7cfcbb8
Add a wire.Value entry to provide a concrete value for the parameter.
Run wire.
Expected behavior
The Go file generated by wire should compile, but it doesn't.
https://travis-ci.com/google/go-cloud/jobs/156507298
Version
bf223a0
The text was updated successfully, but these errors were encountered: