fix(temporary): reorder imports to work around protobuf.js problem #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently protobuf.js is not currently importing the Any type when any.proto is last in the import list, but the import does work if any.proto is higher in the import list. Pending a fix for this in protobuf.js, this change imports any.proto earlier to avoid triggering the problem. When protobuf.js if fixed, we can revert the change.
alexander-fenster
approved these changes
Dec 6, 2023
vchudnov-g
added a commit
that referenced
this pull request
Jul 31, 2024
This commit restores proto imports in the intended order, undoing the workaround in #108 due to protobufjs/protobuf.js#1954 now that the solution protobufjs/protobuf.js#1960 is implemented.
vchudnov-g
added a commit
that referenced
this pull request
Oct 10, 2024
…,ListValue,Struct} (#131) The converter will now recognize a `format` specifier in certain schemas. Specifically, the following combinations are now recognized and result in a protobuf field whose type is the specified `format`: | Discovery `"type"` | Discovery `"format"` | |--------------------|-----------------------------| | `object` | `google.protobuf.Struct` | | `any` | `google.protobuf.Value` | | `array` | `google.protobuf.ListValue` | Note that, as was the case previously, other schemas with `"type" = "any"` and any other `format`, including none, are not accepted unless they are in an `error.details` field. (Googlers, see also cl/683528084.) Incidentally, this PR also restores proto imports in the intended order, undoing the workaround in #108 due to protobufjs/protobuf.js#1954 now that the solution protobufjs/protobuf.js#1960 is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently,
protobuf.jsis not currently importing theAnytype whenany.protois last in the import list, but the import does work ifany.protois higher in the import list. Pending a fix for this inprotobuf.js, this change importsany.protoearlier to avoid triggering the problem. Whenprotobuf.jsis fixed, we can revert the change to maintain alphabetical ordering of imports.