Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test application cleanup #1639

Merged
merged 2 commits into from
Aug 6, 2024
Merged

fix: test application cleanup #1639

merged 2 commits into from
Aug 6, 2024

Conversation

leahecole
Copy link
Contributor

successor to #1636
More test cleanup:

  • removed surrounding promises in retries test and instead threw errors directly - makes it more readable
  • made sure there was proper stream ending and checking for stream end vs. closure where appropriate. The .on('close') check is missing in a couple of spots intentionally and will be added in a subsequent PR that adjusts some stream handoff functionality in retries

@leahecole leahecole requested review from a team as code owners August 5, 2024 21:31
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 5, 2024
@leahecole leahecole merged commit 76ac496 into main Aug 6, 2024
21 checks passed
@leahecole leahecole deleted the cleanup_retries branch August 6, 2024 13:44
@release-please release-please bot mentioned this pull request Aug 6, 2024
Merged
@snyk-io snyk-io bot mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
This was referenced Sep 25, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees

@danielbankhead danielbankhead

Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leahecole @danielbankhead