-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workforce config support. #1251
Merged
gcf-merge-on-green
merged 15 commits into
googleapis:main
from
xil222:xinxinxin-workforcesupport
Sep 28, 2021
Merged
feat: add workforce config support. #1251
gcf-merge-on-green
merged 15 commits into
googleapis:main
from
xil222:xinxinxin-workforcesupport
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 13, 2021
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 14, 2021
lsirac
reviewed
Sep 15, 2021
lsirac
reviewed
Sep 16, 2021
lsirac
reviewed
Sep 16, 2021
lsirac
reviewed
Sep 17, 2021
…2/google-auth-library-nodejs into xinxinxin-workforcesupport
lsirac
reviewed
Sep 21, 2021
bojeil-google
suggested changes
Sep 23, 2021
lsirac
approved these changes
Sep 24, 2021
@xil222 will take a look as soon as @bojeil-google has given 👍 |
ok, thanks |
bojeil-google
suggested changes
Sep 24, 2021
…2/google-auth-library-nodejs into xinxinxin-workforcesupport
bojeil-google
suggested changes
Sep 25, 2021
bojeil-google
approved these changes
Sep 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good from my end. Thanks a lot for putting this together!
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Sep 28, 2021
bcoe
approved these changes
Sep 28, 2021
bcoe
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Sep 28, 2021
bcoe
changed the title
feat: Add workforce config support.
feat: add workforce config support.
Sep 28, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Sep 28, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 28, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [7.10.0](https://github.com/googleapis/google-auth-library-nodejs/compare/v7.9.2...v7.10.0) (2021-09-28) ### Features * add workforce config support. ([#1251](https://github.com/googleapis/google-auth-library-nodejs/issues/1251)) ([fe29e38](https://github.com/googleapis/google-auth-library-nodejs/commit/fe29e384820f1c97ca62478c55813aad3f8ecbea)) --- This PR was generated with [Release Please](https:/googleapis/release-please). See [documentation](https:/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go/workforce-pools-client-support.
Add support of work_force_user_config field for workforce pool and related logic in ExternalClient(calling constructor for IdentityPoolClient) BaseExternalClient(the parent class of IdentityPoolClient).
The logic change is only related to refreshAccessToken() flow, since this API is non-public, we use getAccessToken() to test the flow instead.
Add 16 tests:
ExternalClient:
BaseExternalClient:
IdentityPoolClient: