Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing Implementation of GoogleAuth.sign() for external account credentials #1397

Merged
merged 3 commits into from
Apr 27, 2022

Conversation

aeitzman
Copy link
Contributor

@aeitzman aeitzman commented Apr 20, 2022

Currently, creating signed storage URLs does not work for external account credentials because the storage library expects client_email to be returned from GoogleAuth.getCredentials(). Changing the logic so the same client email that is used to the sign the blob (extracted from the Service Account Impersonation URL) is returned from the getCredentials() call.

Fixes #1239 🦕

…credentials

Currently, creating signed storage URLs does not work for external account credentials because the storage library expects client_email to be returned from GoogleAuth.getCredentials(). Changing the logic so the same client email that is used to the sign the blob (extracted from the Service Account Impersonation URL) is returned from the getCredentials() call.

Fixes googleapis#1239
@aeitzman aeitzman requested review from a team as code owners April 20, 2022 22:00
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 20, 2022
@aeitzman
Copy link
Contributor Author

@lsirac

@lsirac lsirac requested a review from bcoe April 20, 2022 22:06
src/auth/googleauth.ts Outdated Show resolved Hide resolved
test/test.googleauth.ts Outdated Show resolved Hide resolved
@lsirac lsirac self-requested a review April 25, 2022 20:13
src/auth/googleauth.ts Outdated Show resolved Hide resolved
src/auth/googleauth.ts Outdated Show resolved Hide resolved
@aeitzman aeitzman added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
@aeitzman aeitzman merged commit b0ddb75 into googleapis:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched signature when signing with impersonated credentials
4 participants