Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update omitted parameter 'hd' #467

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Update omitted parameter 'hd' #467

merged 1 commit into from
Sep 7, 2018

Conversation

ellemedit
Copy link
Contributor

reference: https://developers.google.com/identity/protocols/OpenIDConnect#authenticationuriparameters

I'm not sure there is need test and how to test.
At this moment, my clients are using the option through casting as any.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

reference: https://developers.google.com/identity/protocols/OpenIDConnect#authenticationuriparameters

I'm not sure there is need test and how to test.
At this moment, my clients are using the option through casting as `any`.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 7, 2018
@ellemedit
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 7, 2018
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@JustinBeckwith JustinBeckwith merged commit 5d6a673 into googleapis:master Sep 7, 2018
@ellemedit ellemedit deleted the update/omitted-param branch September 8, 2018 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants