Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add token_info_url to external account credentials #1168

Merged
merged 15 commits into from
Oct 27, 2022
Merged

feat: add token_info_url to external account credentials #1168

merged 15 commits into from
Oct 27, 2022

Conversation

ScruffyProdigy
Copy link
Contributor

Also some minor refactoring

lsirac
lsirac approved these changes Oct 25, 2022
View reviewed changes
google/auth/external_account.py Outdated Show resolved Hide resolved
google/auth/external_account.py Show resolved Hide resolved
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2022
@BigTailWolf BigTailWolf self-requested a review October 27, 2022 03:11
BigTailWolf
BigTailWolf approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@BigTailWolf BigTailWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very helpful changes. Then the pluggable auth won't be done in a dirty way.

sai-sunder-s
sai-sunder-s approved these changes Oct 27, 2022
View reviewed changes
google/auth/external_account.py Show resolved Hide resolved
tests/test_aws.py Show resolved Hide resolved
tests/test_external_account.py Show resolved Hide resolved
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@ScruffyProdigy ScruffyProdigy added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2022
@ScruffyProdigy ScruffyProdigy merged commit 9adee75 into googleapis:main Oct 27, 2022
@ScruffyProdigy ScruffyProdigy deleted the token_info branch October 27, 2022 23:39
@release-please release-please bot mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-sunder-s sai-sunder-s sai-sunder-s approved these changes

@aeitzman aeitzman aeitzman left review comments

@lsirac lsirac lsirac approved these changes

@clundin25 clundin25 clundin25 left review comments

@BigTailWolf BigTailWolf BigTailWolf approved these changes

@arithmetic1728 arithmetic1728 Awaiting requested review from arithmetic1728

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ScruffyProdigy @BigTailWolf @sai-sunder-s @aeitzman @lsirac @clundin25