chore: Modify exponential backoff implementation to have no initial sleep #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unintuitive that the initial attempt in the exponential backoff loop sleeps. This can lead to subtle bugs in future call sites. This patch refactors the exponential backoff to begin sleeping on the 2nd iteration so requests can be done in a single for loop.
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
arithmetic1728
approved these changes
Jul 11, 2024
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: No sleep on initial attempt in exponential backoff implementation