Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update opentelemetry to v1.14.0 #13627

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Feb 19, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
io_opentelemetry_cpp http_archive minor v1.13.0 -> v1.14.0
open-telemetry/opentelemetry-cpp minor v1.13.0 -> v1.14.0

Release Notes

open-telemetry/opentelemetry-cpp (io_opentelemetry_cpp)

v1.14.0: release

Compare Source

v1.14.0 release

Release of core packages

  • opentelemetry-api
  • opentelemetry-sdk

and exporter packages:

  • opentelemetry-exporter-otlp (gRPC + HTTP/JSON)
  • opentelemetry-exporter-prometheus
What's Changed
Breaking Changes:
  • [REMOVAL] Remove option WITH_OTLP_HTTP_SSL_PREVIEW
    #​2435
    • CMake options WITH_OTLP_HTTP_SSL_PREVIEW and
      WITH_OTLP_HTTP_SSL_TLS_PREVIEW are removed. Building opentelemetry-cpp
      without SSL support is no longer possible.
New Contributors

Full Changelog: open-telemetry/opentelemetry-cpp@v1.13.0...v1.14.0


Configuration

📅 Schedule: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.


This change is Reviewable

@dpebot
Copy link
Collaborator

dpebot commented Feb 19, 2024

/gcbrun

@dbolduc
Copy link
Member

dbolduc commented Feb 19, 2024

@coryan
Copy link
Contributor

coryan commented Feb 21, 2024

open-telemetry/opentelemetry-cpp#2488 (comment) 😠

I agree with the sentiment, but what do you want to do? Do we need to implement the new virtual function (abstract or not) in the exporter? How do we handle support for old OTel libraries?

@dbolduc
Copy link
Member

dbolduc commented Feb 21, 2024

what do you want to do?

Define the override if otel >= 1.14. It is on my TODO list.

https:/open-telemetry/opentelemetry-cpp/blob/2f3fbd48b7de396ab870c95016f629499f32161e/api/include/opentelemetry/version.h#L14-L16

@dpebot
Copy link
Collaborator

dpebot commented Feb 22, 2024

/gcbrun

@dbolduc
Copy link
Member

dbolduc commented Feb 22, 2024

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (6d4123a) to head (31ce14c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13627      +/-   ##
==========================================
- Coverage   93.28%   93.28%   -0.01%     
==========================================
  Files        2229     2229              
  Lines      193816   193816              
==========================================
- Hits       180807   180806       -1     
- Misses      13009    13010       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@dpebot
Copy link
Collaborator

dpebot commented Feb 23, 2024

/gcbrun

@dpebot
Copy link
Collaborator

dpebot commented Feb 23, 2024

/gcbrun

@dbolduc dbolduc merged commit c057b96 into googleapis:main Feb 23, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants