Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigtable): add change stream config to create and update table #8180

Merged
merged 2 commits into from
Jul 5, 2023
Merged

feat(bigtable): add change stream config to create and update table #8180

merged 2 commits into from
Jul 5, 2023

Conversation

tonytanger
Copy link
Contributor

No description provided.

@tonytanger tonytanger requested review from bhshkh and a team as code owners June 27, 2023 21:23
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 27, 2023
@tonytanger tonytanger changed the title Add create and update table with change stream config feat: add change stream config to create and update table Jun 27, 2023
@tonytanger tonytanger changed the title feat: add change stream config to create and update table feat(bigtable): add change stream config to create and update table Jun 27, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 28, 2023
@tonytanger tonytanger force-pushed the add_change_stream branch 2 times, most recently from 4e90fa3 to afdc75c Compare June 29, 2023 18:54
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

mutianf
mutianf reviewed Jul 5, 2023
View reviewed changes
bigtable/admin.go
@@ -269,6 +276,10 @@ func (ac *AdminClient) CreateTableFromConf(ctx context.Context, conf *TableConf)
} else if conf.DeletionProtection == Unprotected {
tbl.DeletionProtection = false
}
if conf.ChangeStreamRetention != nil && conf.ChangeStreamRetention.(time.Duration) != 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check the retention is between 1 and 7?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should leave that up to server side validation https://google.aip.dev/client-libraries/4223

bigtable/admin.go
}

// UpdateTableWithChangeStream updates a table to with the given table ID and change stream config.
func (ac *AdminClient) UpdateTableWithChangeStream(ctx context.Context, tableID string, changeStreamRetention ChangeStreamRetention) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, do we need to check the retention is between 1 and 7?

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 5, 2023
@mutianf mutianf merged commit 32897ce into googleapis:main Jul 5, 2023
@release-please release-please bot mentioned this pull request Jul 5, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 7, 2023
@release-please
chore(main): release bigtable 1.19.0 (#7125)
c992115 
🤖 I have created a release *beep* *boop*
---


## [1.19.0](https://togithub.com/googleapis/google-cloud-go/compare/bigtable/v1.18.1...bigtable/v1.19.0) (2023-07-06)


### Features

* **bigtable:** Add change stream config to create and update table ([#8180](https://togithub.com/googleapis/google-cloud-go/issues/8180)) ([32897ce](https://togithub.com/googleapis/google-cloud-go/commit/32897cec9be7413fa09b403199980e782ae52107))
* **bigtable:** Update all direct dependencies ([b340d03](https://togithub.com/googleapis/google-cloud-go/commit/b340d030f2b52a4ce48846ce63984b28583abde6))
* **bigtable:** Update iam and longrunning deps ([91a1f78](https://togithub.com/googleapis/google-cloud-go/commit/91a1f784a109da70f63b96414bba8a9b4254cddd))


### Bug Fixes

* **bigtable:** REST query UpdateMask bug ([df52820](https://togithub.com/googleapis/google-cloud-go/commit/df52820b0e7721954809a8aa8700b93c5662dc9b))
* **bigtable:** Update grpc to v1.55.0 ([1147ce0](https://togithub.com/googleapis/google-cloud-go/commit/1147ce02a990276ca4f8ab7a1ab65c14da4450ef))
* **bigtable:** Use fieldmask directly instead of field_mask genproto alias ([#8032](https://togithub.com/googleapis/google-cloud-go/issues/8032)) ([cae6cd6](https://togithub.com/googleapis/google-cloud-go/commit/cae6cd6d0e09e98157879fb03fb23f718f4d2bb3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@bhshkh bhshkh mentioned this pull request Sep 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

@bhshkh bhshkh Awaiting requested review from bhshkh

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonytanger @mutianf