fix: untyped string array type #2011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
olavloite
reviewed
Mar 4, 2024
| @@ -629,6 +630,10 @@ function getType(value: Value): Type { | |||
| return {type: 'bool'}; | |||
| } | |||
|
|
|||
| if (is.string(value) && isArrayValue) { | |||
| return {type: 'string'}; | |||
There was a problem hiding this comment.
I don't understand this. Why are we returning type: 'string' if the value is an array and a string? What happens now if the value is a string, but not an array? Then the return type will be unspecified, right? While it now is string.
And why do we want to return type: 'string' for array values, and not array<string>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2009