-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: feat: instrument src/ with traces using OpenTelemetry #2087
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
size: xl
Pull request size is extra large.
api: spanner
Issues related to the googleapis/nodejs-spanner API.
labels
Aug 1, 2024
odeke-em
force-pushed
the
instrument-with-opentelemetry
branch
5 times, most recently
from
August 4, 2024 00:15
49bb7b9
to
e848ff1
Compare
@surbhigarg92 this PR is ready for review! |
odeke-em
force-pushed
the
instrument-with-opentelemetry
branch
7 times, most recently
from
August 8, 2024 19:28
177cb35
to
0292910
Compare
odeke-em
changed the title
feat: instrument src/ with traces using OpenTelemetry
DO NOT MERGE: feat: instrument src/ with traces using OpenTelemetry
Aug 9, 2024
odeke-em
force-pushed
the
instrument-with-opentelemetry
branch
from
August 16, 2024 17:17
1a9d9dd
to
197828a
Compare
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Aug 17, 2024
This change adds the scaffolding for instrumentation along with tests for the tracing mechanisms that'll be used to trace the entire package. Built from googleapis#2087 Updates googleapis#2079
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Aug 17, 2024
This change adds the scaffolding for instrumentation along with tests for the tracing mechanisms that'll be used to trace the entire package. Built from googleapis#2087 Updates googleapis#2079
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Aug 30, 2024
This change adds the scaffolding for instrumentation along with tests for the tracing mechanisms that'll be used to trace the entire package. Built from googleapis#2087 Updates googleapis#2079
odeke-em
force-pushed
the
instrument-with-opentelemetry
branch
from
August 30, 2024 08:56
197828a
to
f509a8a
Compare
surbhigarg92
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Aug 30, 2024
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 22, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 22, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 22, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 22, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 22, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 22, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 22, 2024
This change adds tracing spans to Session for methods: * create * getMetadata * keepAlive and corresponding tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
This change adds tracing spans to Session for methods: * create * getMetadata * keepAlive and corresponding tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
This change adds tracing spans to Session for methods: * create * getMetadata * keepAlive and corresponding tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
This change adds tracing spans to Session for methods: * create * getMetadata * keepAlive and corresponding tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
This change adds tracing spans to Session for methods: * create * getMetadata * keepAlive and corresponding tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
Adds trace spans for Database methods, as well as tests for methods: * getSession * getSnapshot * run * runStream * runTransaction tracing of other methods shall come in follow-up PRs. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
Adds trace spans for Database methods, as well as tests for methods: * getSession * getSnapshot * run * runStream * runTransaction tracing of other methods shall come in follow-up PRs. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 23, 2024
Adds trace spans for Database methods, as well as tests for methods: * getSession * getSnapshot * run * runStream * runTransaction tracing of other methods shall come in follow-up PRs. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 30, 2024
Adds trace spans for Database methods, as well as tests for methods: * getSession * getSnapshot * run * runStream * runTransaction tracing of other methods shall come in follow-up PRs. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 30, 2024
This change adds tracing spans to Session for methods: * create * getMetadata * keepAlive and corresponding tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 30, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Sep 30, 2024
Adds trace spans for Database methods, as well as tests for methods: * getSession * getSnapshot * run * runStream * runTransaction tracing of other methods shall come in follow-up PRs. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Oct 1, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Oct 1, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Oct 1, 2024
This change adds observability tracing for Transaction along with tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Oct 3, 2024
This change adds observability tracing for Transaction along with tests. Alsoo while here, added SessionPool.createSessions span. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Oct 3, 2024
This change adds observability tracing for Transaction along with tests. Alsoo while here, added SessionPool.createSessions span. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
Successfully dissected and no longer necessary! |
odeke-em
added a commit
to odeke-em/nodejs-spanner
that referenced
this pull request
Oct 10, 2024
This change traces Session methods: * create * delete Updaes googleapis#2087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/nodejs-spanner API.
size: xl
Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements tracing of RPC calls using
OpenTelemetry to aid in providing observability.
Fixes #2079