Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (observability) propagate database name for every span generated to aid in quick debugging #2155

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: (observability) propagate database name for every span generated to aid in quick debugging #2155

merged 1 commit into from
Oct 10, 2024

Conversation

odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Oct 9, 2024 •
edited
Loading

With this change customers shall always be able to identify which database is being connected to.

Updates #2079

Exhibit

Screenshot 2024-10-08 at 10 52 56 PM

@odeke-em odeke-em requested review from a team as code owners October 9, 2024 05:51
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Oct 9, 2024
surbhigarg92
surbhigarg92 approved these changes Oct 10, 2024
View reviewed changes
src/database.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 10, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 10, 2024
@odeke-em
feat: (observability) propagate database name for every span generate…
614c69b 
…d to aid in quick debugging

With this change customers shall always be able to identify which
database is being connected to.

Updates googleapis#2079
@odeke-em odeke-em force-pushed the trace-propagate-database-name branch from 0c902ad to 614c69b Compare October 10, 2024 10:57
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 10, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 10, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0342e74 into googleapis:main Oct 10, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 10, 2024
@release-please release-please bot mentioned this pull request Oct 10, 2024
Open
@odeke-em odeke-em deleted the trace-propagate-database-name branch October 10, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odeke-em @surbhigarg92 @yoshi-kokoro @alkatrivedi