Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(observability): trace Database.batchWriteAtLeastOnce #2157

Merged

Conversation

odeke-em
Copy link
Contributor

This change traces Database.batchWriteAtLeastOnce. Sadly though MockSpanner doesn't yet support batch writes hence no end-to-end test with it.

Updates #2079

@odeke-em odeke-em requested review from a team as code owners October 11, 2024 09:20
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Oct 11, 2024
@odeke-em odeke-em force-pushed the trace-Database.batchWriteAtLeastOnce branch from aafda49 to 438bfd4 Compare October 11, 2024 09:23
This change traces Database.batchWriteAtLeastOnce. Sadly though
MockSpanner doesn't yet support batch writes hence no end-to-end
test with it.

Updates googleapis#2079
@odeke-em odeke-em force-pushed the trace-Database.batchWriteAtLeastOnce branch from 438bfd4 to a4d4b66 Compare October 14, 2024 19:32
@odeke-em
Copy link
Contributor Author

@alkatrivedi @surbhigarg92 @harshachinta kindly help me run the bots. Thank you!

@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 16, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2024
@surbhigarg92 surbhigarg92 merged commit 2a19ef1 into googleapis:main Oct 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants