Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append extra file changes in pull request #343

Closed
gengjiawen opened this issue Aug 16, 2021 · 7 comments · Fixed by #410
Closed

append extra file changes in pull request #343

gengjiawen opened this issue Aug 16, 2021 · 7 comments · Fixed by #410

Comments

@gengjiawen
Copy link

gengjiawen commented Aug 16, 2021

I have other files to squash into the release pr. E.g version number in docs.

Is there an easy way to do this ? My thought is to add an extra-files to do this ?

      - uses: GoogleCloudPlatform/release-please-action@v2
        id: release
        with:
          package-name: monkey-rust
          token: ${{ secrets.GITHUB_TOKEN }}
          release-type: rust
          extra-files: node patch-my-file.js		

This also will fix https:/google-github-actions/release-please-action/issues/180

My current workaround is to change gengjiawen/monkey-rust#57 directly, but it's cumbersome.

cc @bcoe

@bcoe
Copy link
Contributor

bcoe commented Aug 16, 2021

Seems like a reasonable feature request, I'm just not sure if it would be better implemented in the action or release-please itself.

@gengjiawen
Copy link
Author

Also I think I need to get version number for the context, maybe through process.env ?

@erezrokah
Copy link

We use the following approach to add commits to release PRs:
https:/netlify/delta-action/blob/bcf66a5aef6897c7cc91cfff5a053874da22cbad/.github/workflows/prepare.yml#L26

if that helps. See https:/stefanzweifel/git-auto-commit-action

@gengjiawen
Copy link
Author

Is this already implemented in googleapis/release-please#852 ? @chingor13

@gengjiawen
Copy link
Author

Friendly ping

@gengjiawen
Copy link
Author

Thanks to @erezrokah , the workaround working. But I don't know why it no longer triggered for newly created release.

https:/gengjiawen/monkey-rust/blob/main/.github/workflows/prepare-release.yml

https:/gengjiawen/monkey-rust/actions/workflows/prepare-release.yml

@jcornaz
Copy link
Contributor

jcornaz commented Jan 3, 2022

@bcoe This is indeed already available in releaes-please itself: googleapis/release-please#1157

We only need the extra-files argument on the github-action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants