Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): allow draft github release #397

Closed
wants to merge 2 commits into from
Closed

feat(input): allow draft github release #397

wants to merge 2 commits into from

Conversation

kalosisz
Copy link

Hi guys,

I really love release-please-action, but it's missing an essential option for me. I'd like to release draft for non-manifest commands as well.

This PR would ammend that and allow the user to create GitHub release as drafts.

Please review. Thanks

@google-cla google-cla bot added the cla: no label Nov 17, 2021
@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 17, 2021
@kalosisz kalosisz changed the title feat: allow draft github release for non-manifest feat(input): allow draft github release Nov 17, 2021
README.md Outdated Show resolved Hide resolved
@kalosisz
Copy link
Author

Hi @bcoe,
Could you please check my PR? Thanks

@bcoe
Copy link
Contributor

bcoe commented Nov 23, 2021

@kalosisz thank you for the patch 👏 we're in the middle of a large refactor of release please, so have been a bit slow to merge anything.

The log jam should unblock soon, and I'm excited to get to this.

@kalosisz
Copy link
Author

@bcoe thanks for pointing the refactor out. based on googleapis/release-please#1104, the draft would be solved by having a single-component manifest

@bcoe
Copy link
Contributor

bcoe commented Nov 30, 2021

@kalosisz I pulled the draft functionality in here.

If you're able to help experiment, testing with additional repos would be great, before we land v3, you can run an early release of the action like this:

google-github-actions/release-please-action@d71a91c8ec10fffa507d18743dd725e54211f3bb

@bcoe bcoe closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants