feat: support forever option #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 62.78% 63.69% +0.91%
==========================================
Files 1 1
Lines 309 314 +5
Branches 23 25 +2
==========================================
+ Hits 194 200 +6
+ Misses 114 113 -1
Partials 1 1
Continue to review full report at Codecov.
|
|
@JustinBeckwith took a shot at some tests and modified the implementation to set the agent in the response request object (request module does this). As a result I had to shuffle some types around, but I think its ok? PTAL! |
| teenyRequest({uri, forever: true}, (err, res) => { | ||
| assert.ifError(err); | ||
| // tslint:disable-next-line no-any | ||
| assert.strictEqual((res.request.agent as any).keepAlive, true); |
There was a problem hiding this comment.
Huh, it's weird that you had to cast this. What's up with that?
There was a problem hiding this comment.
The Agent type is missing a number of properties :[
JustinBeckwith
approved these changes
Jul 19, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #48
So admittedly this only adds support for non-proxy users. However my goal is to resolve googleapis/nodejs-bigquery#41, which appears to mainly affect GCF users, so I think its ok to not include proxy support?