fix: remove unused logging #71
Conversation
googlebot
added
the
cla: yes
| @@ -215,7 +215,7 @@ function teenyRequest( | |||
| const multipart = reqOpts.multipart as RequestPart[]; | |||
| if (reqOpts.multipart && multipart.length === 2) { | |||
| if (!callback) { | |||
| console.log('Error, multipart without callback not implemented.'); | |||
| console.error('multipart without callback not implemented.'); | |||
There was a problem hiding this comment.
Shouldn't we throw an exception or something in this case?
There was a problem hiding this comment.
I have always been under the impression that trying to log like this is not awesome for libraries. The only case (I can think of) where the callback wasn't defined is if the user was expecting to get a stream back. In that case ... throwing feels correct, but also highly scary as folks are unlikely to catch it.
There was a problem hiding this comment.
my gut was an exception should be thrown here too, but I'm also feeling like we're down a rabbit hole, I want us to be back to a working version of teeny-request in @google-cloud/storage as soon as possible.
Let's log some tickets for this?
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 68.1% 68.49% +0.39%
==========================================
Files 1 1
Lines 348 346 -2
Branches 28 28
==========================================
Hits 237 237
+ Misses 110 108 -2
Partials 1 1
Continue to review full report at Codecov.
|
No description provided.