fix: Make all listeners null by default #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
romainpiel
force-pushed
the
romainpiel/nullable-listeners
branch
from
467a599
to
7721994
Compare
romainpiel
changed the title
Prior to this change, all click listeners and onMapLoaded were set to an empty lambda by default. This would cause issues where for example the map is clickable by default without doing anything. When talkback is on, it reads "double click to activate". This change fixes that by making all listeners null by default.
romainpiel
force-pushed
the
romainpiel/nullable-listeners
branch
from
7721994
to
82b3225
Compare
wangela
approved these changes
Sep 13, 2023
|
Thank you for this fix, @romainpiel! Marking this a chore so it gets bundled with a couple of other changes in a planned release. |
|
🎉 This PR is included in version 2.14.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, all click listeners and onMapLoaded were set to an empty lambda by default. This would cause issues where for example the map is clickable by default without doing anything. When talkback is on, it reads "double click to activate".
This change fixes that by making all listeners null by default.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #38 🦕