Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README.md #328

Closed
wants to merge 3 commits into from
Closed

chore: Update README.md #328

wants to merge 3 commits into from

Conversation

RxDx
Copy link

@RxDx RxDx commented Jun 22, 2023

Update dependencies:

  • maps-compose (2.11.2 -> 2.11.4)
  • maps-compose-utils (2.11.2 -> 2.11.4)
  • maps-compose-widgets (2.11.2 -> 2.11.4)

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@google-cla
Copy link

google-cla bot commented Jun 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kikoso
Copy link
Collaborator

kikoso commented Jul 7, 2023

Hi @RxDx !

It seems that we are using 18.0.2 for the Play Services Maps version, isn't it?

We also require commits to follow a semantic pattern. Could you make sure it is following that structure? You can see exactly what we are checking here: https:/googlemaps/.github/blob/master/.github/semantic.yml

Thanks!

@kikoso
Copy link
Collaborator

kikoso commented Jul 16, 2023

LGTM!

@wangela
Copy link
Member

wangela commented Jul 19, 2023

Thanks for this update, @RxDx. Our automatic README updaes are failling due to #301. Also filed #337 to get us up to date on the Maps SDK dependency.

@wangela
Copy link
Member

wangela commented Jul 26, 2023

Now that #301 is fixed, this PR is obsolete. Thank you @RxDx for helping keep our README up to date while our automations were down.

@wangela wangela closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants