feat: allow displaying grid for y and row channels
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangqianwen0418, I added grids as well. Can you take a look if they look okay? |
|
@sehilyi , it looks great! Just have one small suggestion, do you think we should add an outline to the circular view? The outline will make the circular view consistent with the linear view. Also, the y axis will not pop out in the circular view.
|
|
Thank you for the suggestion! Yes, I think we should show the outline. It will make the boundaries between tracks more visually clear. I will open a separate PR to support that! |
sehilyi
changed the title
y and row channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for displaying grid lines for
y-axis androw.Usage:
Customization:
Screenshots:
Fix #29
Discussion #373 (comment)