feat(upload): add support for streamed uploads of Big File #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Streamed uploads](https://core.telegram.org/api/files#streamed-uploads) - A total_stream_size variable must be used to keep track of the total number of bytes read from the stream. - upload.saveBigFilePart must always be used, even if the stream turns out to be smaller than 10MB. - The file_total_parts field must be set to -1 for all parts except for the last one, using the following logic:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1436 +/- ##
==========================================
+ Coverage 71.02% 71.08% +0.05%
==========================================
Files 442 442
Lines 17744 17753 +9
==========================================
+ Hits 12602 12619 +17
+ Misses 4209 4202 -7
+ Partials 933 932 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streamed uploads
A total_stream_size variable must be used to keep track of the total number of bytes read from the stream.
upload.saveBigFilePart must always be used, even if the stream turns out to be smaller than 10MB.
The file_total_parts field must be set to -1 for all parts except for the last one, using the following logic: