Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for selecting files when using -i flag #725

Closed
AntonOsika opened this issue Sep 20, 2023 · 7 comments
Closed

Improve UX for selecting files when using -i flag #725

AntonOsika opened this issue Sep 20, 2023 · 7 comments

Comments

@AntonOsika
Copy link
Collaborator

AntonOsika commented Sep 20, 2023

Improve the user experience for selecting files

  • Generate a tree (instead of list) representation of the code (workspace) in a text file. Similar to output of tree command
  • Allow users to edit this file directly.
  • Users can comment out files they do not want to feed into the LLM prompt.
  • Include instructions within comments of the generated text file to explain how to use the file.
  • Implement as the primary method for selecting files.
  • Let the CLI give the user the option to open the file list in the default editor (rather than using tkinter tool)
  • Benefit: Users can use their editors and toggle file selections using IDE keyboard shortcuts, tailoring their experience with the GPT engineer.

More nice to haves:

  • Let it be a .toml file, which supports comments
  • Allow syntax for excluding patterns. Such as node_modules __pycache__ *.pyc in the .toml file
  • Support having multiple "configs" in the .toml file, that can be selected with CLI argument. Useful for asking for edits in separate parts of codebase
@ATheorell
Copy link
Collaborator

This task supersedes #667 -> implementing #725 solves #667

@similato87
Copy link
Collaborator

Hi @ATheorell ,

I've implemented the tree-style file selection feature in the recent PR(#937) and would greatly appreciate your review. This update simplifies the file selection process for users, allowing them to choose files via a .toml configuration directly from the terminal and view their selections in a tree-style format. There is a GIF showing the process in the PR.

Please take a look at the changes and provide your feedback. Also, it would be helpful to know if there are any additional requirements for tests or if you'd like to see more features or enhancements related to this update.

@TheoMcCabe
Copy link
Collaborator

Closing as similato has done great work on this

@PierrunoYT
Copy link

I don't like it

@captivus
Copy link
Collaborator

captivus commented Feb 13, 2024

I don't like it

This is unhelpful @PierrunoYT. We'd welcome PRs reflecting thoughtful input.

@PierrunoYT
Copy link

I don't like it

This is unhelpful. We'd welcome PRs reflecting thoughtful input.

I posted some ideas

@captivus
Copy link
Collaborator

That doesn't give you license to subsequently post unhelpful remarks. Please be helpful and productive.

Closing this thread. Thanks again for your work @similato87!

@gpt-engineer-org gpt-engineer-org locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants