Improve Error Handling to Include Full Stack Trace #1118
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 95e2e7a
- Looked at
64lines of code in2files - Took 44 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_UZjDCK4HTk3YlOfr
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
| "Change the program to print 'Goodbye, World!' instead of 'Hello, World!'" | ||
| ) | ||
|
|
||
| try: |
There was a problem hiding this comment.
The test case 'test_handle_improve_mode_multilayer_error_trace' is not correctly testing the functionality of the 'handle_improve_mode' function. The test case is expecting an exception to be raised, but the 'handle_improve_mode' function is designed to catch all exceptions and print their stack trace, not to raise them. Therefore, the test case will always fail as it is currently written.
|
It looks to me like the full stack trace is now being dumped to stdout, when errors are encountered in improve mode, which is the requested behavior.
@AntonOsika if you're good with the above, this should be ready to merge. #1110 |
This PR introduces an enhancement to our error handling mechanism in the
handle_improve_modefunction for issue #1110. Previously, when an exception was caught, only the top-level error message was printed. This made it difficult to debug issues, especially those involving nested exceptions.Changes include:
tracebackmodule to enable printing of full stack traces.exceptblock in thehandle_improve_modefunction to print the full stack trace of exceptions.test_steps.pyto verify that the full stack trace is printed for multi-layer exceptions.Summary:
This PR enhances error handling in the
handle_improve_modefunction by printing full stack traces of exceptions and adds a corresponding test case.Key points:
tracebackmodule in/gpt_engineer/core/default/steps.py.exceptblock inhandle_improve_modefunction to print full stack trace of exceptions./tests/core/default/test_steps.pyto verify full stack trace printing for multi-layer exceptions.Generated with ❤️ by ellipsis.dev