Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Java context propagation #1260

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Conversation

grcevski
Copy link
Contributor

This PR introduces one fix and one improvement.

  1. The code I had added for TC based L4 context propagation initially had some dead code which was invalid and we were mistakenly detecting spans with stale information.
  2. Sometimes Java thread pools will connect on the parent thread to resolve the downstream service and then kick off a new thread pool thread to handle the outgoing connection. We can use this correlation to find the parent span, so I added extra code for matching based on the connection info.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (0c09fd8) to head (a66f88d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
+ Coverage   78.11%   81.77%   +3.65%     
==========================================
  Files         135      135              
  Lines       11384    11384              
==========================================
+ Hits         8893     9309     +416     
+ Misses       1952     1546     -406     
+ Partials      539      529      -10     
Flag Coverage Δ
integration-test 60.60% <ø> (+0.39%) ⬆️
k8s-integration-test 59.07% <ø> (?)
oats-test 36.42% <ø> (-0.05%) ⬇️
unittests 53.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski grcevski merged commit b833735 into grafana:main Oct 15, 2024
12 checks passed
@grcevski grcevski deleted the better_java_tracking branch October 15, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants