Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring disabled informers in beyla-k8s-cache #1264

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

mariomac
Copy link
Contributor

@mariomac mariomac commented Oct 17, 2024

Restoring the configuration of disabled informers, after updating them to the new cache library (please see vendor changes for more insights).

For Beyla 2.0, we might consider to remove this configuration feature in favor of just externalizing the load to https:/grafana/beyla-k8s-cache (less configuration options to implement, document and support).

@mariomac mariomac changed the title Restoring disabled informers in new library Restoring disabled informers in the new library Oct 17, 2024
@mariomac mariomac changed the title Restoring disabled informers in the new library Restoring disabled informers in beyla-k8s-cache Oct 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.44%. Comparing base (233fd32) to head (8b0ed90).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/kube/informer_provider.go 42.30% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   81.76%   79.44%   -2.33%     
==========================================
  Files         131      131              
  Lines       11041    11051      +10     
==========================================
- Hits         9028     8779     -249     
- Misses       1502     1748     +246     
- Partials      511      524      +13     
Flag Coverage Δ
integration-test 62.13% <38.46%> (-0.02%) ⬇️
k8s-integration-test ?
oats-test 37.11% <7.69%> (-0.07%) ⬇️
unittests 53.85% <11.53%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariomac mariomac merged commit 36ec19c into grafana:main Oct 17, 2024
9 of 10 checks passed
@mariomac mariomac deleted the restore-disable-informers branch October 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants