Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backport workflow to cherry-pick PR merge commits to other long-lived branches #553

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jan 17, 2024

Taking a look at the backport Action.

GitHub token with issue, comment, and label read/write permissions

It looks to be covered by the default permissions for GITHUB_TOKEN.

I'm guessing that the Action does require extra permissions since all other instances of the workflow are using PATs or apps but we can test this by merging this PR and trying a backport.

Use of the workflow is documented in Backport changes although the documentation is pretty specific to Grafana, the workflow will behave similarly here.

Taking a look at the [backport Action](https:/grafana/grafana-github-actions/blob/main/backport/action.yml#L5).

> GitHub token with issue, comment, and label read/write permissions

It looks to be covered by the default permissions for [`GITHUB_TOKEN`](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token).

I'm guessing that the Action does require extra permissions since all other instances of the workflow are using PATs or apps but we can test this by merging this PR and trying a backport.

Signed-off-by: Jack Baldry <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6925666) 79.32% compared to head (db1639c) 79.16%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   79.32%   79.16%   -0.16%     
==========================================
  Files          69       69              
  Lines        5828     5828              
==========================================
- Hits         4623     4614       -9     
- Misses        984      995      +11     
+ Partials      221      219       -2     
Flag Coverage Δ
integration-test 68.71% <ø> (-0.30%) ⬇️
unittests 45.06% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jdbaldry jdbaldry merged commit 06a0246 into main Jan 17, 2024
4 checks passed
@jdbaldry jdbaldry deleted the jdb/2024-01-install-backport-workflow branch January 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants