Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes to k8s-walkthrough.md #554

Merged
merged 2 commits into from
Jan 18, 2024
Merged

minor fixes to k8s-walkthrough.md #554

merged 2 commits into from
Jan 18, 2024

Conversation

mariomac
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06a0246) 79.19% compared to head (39dda71) 79.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   79.19%   79.05%   -0.14%     
==========================================
  Files          69       69              
  Lines        5830     5830              
==========================================
- Hits         4617     4609       -8     
- Misses        990      996       +6     
- Partials      223      225       +2     
Flag Coverage Δ
integration-test 68.48% <ø> (-0.39%) ⬇️
unittests 45.04% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@mariomac mariomac merged commit 896bc89 into grafana:main Jan 18, 2024
5 checks passed
@mariomac mariomac deleted the fix-doc branch January 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants