Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix other instances of SQSClient queuesResponse examples #1754

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heitortsergent
Copy link
Collaborator

What?

Fix SQSClient examples that use queuesResponse.queueUrls instead of queuesResponse.urls.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

Related to #1733.

@heitortsergent heitortsergent self-assigned this Sep 30, 2024
@heitortsergent heitortsergent added Area: OSS Content Improvements or additions to community/oss documentation type/docs examples Issues about a missing example labels Sep 30, 2024
@heitortsergent
Copy link
Collaborator Author

@oleiade this is related to the community PR that caught the issue in one of SQSClient examples. I searched across the repo and found a few more instances.

If you can please let me know if this looks right, and I can fix this in the previous versions as well. 🙏

Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🚀 Thanks for taking a more throrough look 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation examples Issues about a missing example type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants