Update latest sobek: bigInt, etc #3913
Conversation
olegbespalov
requested review from
mstoykov and
codebien
and removed request for
a team
|
Okay, it's not so straightforward:sweat_smile: I will look at the tc39 tests and adjust them accordingly. +1: For now covering PR to a draft |
olegbespalov
force-pushed
the
dep/sobek
branch
from
e5fcae9
to
f171639
Compare
olegbespalov
added
the
breaking change
| if (value.join(":") !== expected.join(":")) { | ||
| throw new Error("Bad RSA public key modulus: " + value.join(":")); | ||
| var value = cert.publicKey ? cert.publicKey.key.n.toString(16) : null; | ||
| var expected = "dff9ea47b4241c3e548db1763502af2da7599bd8675620d82a5c547db766d928ff8126cbaf62d193976afa0c7bec872d50504cfd948d0d244c2fb63a6499720d8d600c6d7e4a4477580f346b5075bea3e6781a2c8bf5debcd2ed7b535b62a0dae5f4801f188b7d19b86cb41795882f8ca8339f2341960733868abce1695c095b488546c38369b8bfc6b182bf4606259ffff46dee808a00c929574357a57604fdd11fb1010174400e1113d906754b18aeec818673f5e2cbde1171c5d78af163a9444df32474458f963cf54bc81ecf8d8b88237db8ffae1a069438fd7cf99ef975037e7c591b60d100cf98e9a65107fd9ba5601d481cac186846e5c96bc8a9dc23"; |
There was a problem hiding this comment.
Note for the reviewers: it's the hex string representation of the bytes from before
| @@ -189,13 +189,6 @@ func TestNewBundle(t *testing.T) { | |||
| "InvalidCompat", "es1", `export default function() {};`, | |||
| `invalid compatibility mode "es1". Use: "extended", "base", "experimental_enhanced"`, | |||
| }, | |||
| // BigInt is not supported | |||
There was a problem hiding this comment.
for reviewers: I dropped the case completely since I am unsure how useful it is. If reviewers find this relevant, we can come up with another not-implemented feature that could be used till the next time
There was a problem hiding this comment.
I don't think it is as useful now that basically compatibility mode is kind of defunct, so 👍
In theory we can replace it with some other functionality that isn't supported ... but 🤷
|
Okay, it's ready for review, but I feel we need to try test this on the webcrypto's, since potentially it could also be affected |
|
Okay, webcrypto set of tests also look good.
|
olegbespalov
added
the
documentation-needed
What?
grafana/sobekThis PR contains a possible breaking change since now sobek could automatically convert the golang's math's bigInt into the
bigintwhenever previously it was another structureWhy?
The sobek has more features, which we would like to bring to k6
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)